mirror of
https://github.com/ggerganov/llama.cpp.git
synced 2024-10-29 22:20:15 +01:00
Fix Docker ROCM builds, use AMDGPU_TARGETS instead of GPU_TARGETS (#9641)
* Fix Docker ROCM builds, use AMDGPU_TARGETS instead of GPU_TARGETS * Set ROCM_DOCKER_ARCH as string due it incorrectly build and cause OOM exit code
This commit is contained in:
parent
511636df0c
commit
6f1d9d71f4
@ -11,7 +11,7 @@ FROM ${BASE_ROCM_DEV_CONTAINER} AS build
|
|||||||
# Unless otherwise specified, we make a fat build.
|
# Unless otherwise specified, we make a fat build.
|
||||||
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
||||||
# This is mostly tied to rocBLAS supported archs.
|
# This is mostly tied to rocBLAS supported archs.
|
||||||
ARG ROCM_DOCKER_ARCH=\
|
ARG ROCM_DOCKER_ARCH="\
|
||||||
gfx803 \
|
gfx803 \
|
||||||
gfx900 \
|
gfx900 \
|
||||||
gfx906 \
|
gfx906 \
|
||||||
@ -21,7 +21,7 @@ ARG ROCM_DOCKER_ARCH=\
|
|||||||
gfx1030 \
|
gfx1030 \
|
||||||
gfx1100 \
|
gfx1100 \
|
||||||
gfx1101 \
|
gfx1101 \
|
||||||
gfx1102
|
gfx1102"
|
||||||
|
|
||||||
COPY requirements.txt requirements.txt
|
COPY requirements.txt requirements.txt
|
||||||
COPY requirements requirements
|
COPY requirements requirements
|
||||||
@ -34,7 +34,7 @@ WORKDIR /app
|
|||||||
COPY . .
|
COPY . .
|
||||||
|
|
||||||
# Set nvcc architecture
|
# Set nvcc architecture
|
||||||
ENV GPU_TARGETS=${ROCM_DOCKER_ARCH}
|
ENV AMDGPU_TARGETS=${ROCM_DOCKER_ARCH}
|
||||||
# Enable ROCm
|
# Enable ROCm
|
||||||
ENV GGML_HIPBLAS=1
|
ENV GGML_HIPBLAS=1
|
||||||
ENV CC=/opt/rocm/llvm/bin/clang
|
ENV CC=/opt/rocm/llvm/bin/clang
|
||||||
|
@ -11,7 +11,7 @@ FROM ${BASE_ROCM_DEV_CONTAINER} AS build
|
|||||||
# Unless otherwise specified, we make a fat build.
|
# Unless otherwise specified, we make a fat build.
|
||||||
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
||||||
# This is mostly tied to rocBLAS supported archs.
|
# This is mostly tied to rocBLAS supported archs.
|
||||||
ARG ROCM_DOCKER_ARCH=\
|
ARG ROCM_DOCKER_ARCH="\
|
||||||
gfx803 \
|
gfx803 \
|
||||||
gfx900 \
|
gfx900 \
|
||||||
gfx906 \
|
gfx906 \
|
||||||
@ -21,7 +21,7 @@ ARG ROCM_DOCKER_ARCH=\
|
|||||||
gfx1030 \
|
gfx1030 \
|
||||||
gfx1100 \
|
gfx1100 \
|
||||||
gfx1101 \
|
gfx1101 \
|
||||||
gfx1102
|
gfx1102"
|
||||||
|
|
||||||
COPY requirements.txt requirements.txt
|
COPY requirements.txt requirements.txt
|
||||||
COPY requirements requirements
|
COPY requirements requirements
|
||||||
@ -34,7 +34,7 @@ WORKDIR /app
|
|||||||
COPY . .
|
COPY . .
|
||||||
|
|
||||||
# Set nvcc architecture
|
# Set nvcc architecture
|
||||||
ENV GPU_TARGETS=${ROCM_DOCKER_ARCH}
|
ENV AMDGPU_TARGETS=${ROCM_DOCKER_ARCH}
|
||||||
# Enable ROCm
|
# Enable ROCm
|
||||||
ENV GGML_HIPBLAS=1
|
ENV GGML_HIPBLAS=1
|
||||||
ENV CC=/opt/rocm/llvm/bin/clang
|
ENV CC=/opt/rocm/llvm/bin/clang
|
||||||
|
@ -11,7 +11,7 @@ FROM ${BASE_ROCM_DEV_CONTAINER} AS build
|
|||||||
# Unless otherwise specified, we make a fat build.
|
# Unless otherwise specified, we make a fat build.
|
||||||
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
# List from https://github.com/ggerganov/llama.cpp/pull/1087#issuecomment-1682807878
|
||||||
# This is mostly tied to rocBLAS supported archs.
|
# This is mostly tied to rocBLAS supported archs.
|
||||||
ARG ROCM_DOCKER_ARCH=\
|
ARG ROCM_DOCKER_ARCH="\
|
||||||
gfx803 \
|
gfx803 \
|
||||||
gfx900 \
|
gfx900 \
|
||||||
gfx906 \
|
gfx906 \
|
||||||
@ -21,7 +21,7 @@ ARG ROCM_DOCKER_ARCH=\
|
|||||||
gfx1030 \
|
gfx1030 \
|
||||||
gfx1100 \
|
gfx1100 \
|
||||||
gfx1101 \
|
gfx1101 \
|
||||||
gfx1102
|
gfx1102"
|
||||||
|
|
||||||
COPY requirements.txt requirements.txt
|
COPY requirements.txt requirements.txt
|
||||||
COPY requirements requirements
|
COPY requirements requirements
|
||||||
@ -34,7 +34,7 @@ WORKDIR /app
|
|||||||
COPY . .
|
COPY . .
|
||||||
|
|
||||||
# Set nvcc architecture
|
# Set nvcc architecture
|
||||||
ENV GPU_TARGETS=${ROCM_DOCKER_ARCH}
|
ENV AMDGPU_TARGETS=${ROCM_DOCKER_ARCH}
|
||||||
# Enable ROCm
|
# Enable ROCm
|
||||||
ENV GGML_HIPBLAS=1
|
ENV GGML_HIPBLAS=1
|
||||||
ENV CC=/opt/rocm/llvm/bin/clang
|
ENV CC=/opt/rocm/llvm/bin/clang
|
||||||
|
2
.github/workflows/build.yml
vendored
2
.github/workflows/build.yml
vendored
@ -1032,7 +1032,7 @@ jobs:
|
|||||||
run: |
|
run: |
|
||||||
$env:HIP_PATH=$(Resolve-Path 'C:\Program Files\AMD\ROCm\*\bin\clang.exe' | split-path | split-path)
|
$env:HIP_PATH=$(Resolve-Path 'C:\Program Files\AMD\ROCm\*\bin\clang.exe' | split-path | split-path)
|
||||||
$env:CMAKE_PREFIX_PATH="${env:HIP_PATH}"
|
$env:CMAKE_PREFIX_PATH="${env:HIP_PATH}"
|
||||||
cmake -G "Unix Makefiles" -B build -S . -DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" -DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" -DGGML_HIPBLAS=ON -DCMAKE_BUILD_TYPE=Release -DGPU_TARGETS=${{ matrix.gpu_target }} -DGGML_RPC=ON
|
cmake -G "Unix Makefiles" -B build -S . -DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" -DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" -DGGML_HIPBLAS=ON -DCMAKE_BUILD_TYPE=Release -DAMDGPU_TARGETS=${{ matrix.gpu_target }} -DGGML_RPC=ON
|
||||||
cmake --build build -j ${env:NUMBER_OF_PROCESSORS}
|
cmake --build build -j ${env:NUMBER_OF_PROCESSORS}
|
||||||
md "build\bin\rocblas\library\"
|
md "build\bin\rocblas\library\"
|
||||||
cp "${env:HIP_PATH}\bin\hipblas.dll" "build\bin\"
|
cp "${env:HIP_PATH}\bin\hipblas.dll" "build\bin\"
|
||||||
|
Loading…
Reference in New Issue
Block a user