From 78fafcaf1042080f745bc5591e921455059ab7af Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Sun, 25 Jun 2023 16:41:53 +0300 Subject: [PATCH] ggml : do not use _GNU_SOURCE gratuitously --- Makefile | 8 ++++++++ ggml.c | 4 +--- llama-util.h | 1 + llama.cpp | 8 -------- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 5dd676fad..1e36eddfe 100644 --- a/Makefile +++ b/Makefile @@ -49,6 +49,14 @@ CFLAGS = -I. $(OPT) -std=c11 -fPIC CXXFLAGS = -I. -I./examples $(OPT) -std=c++11 -fPIC LDFLAGS = +# clock_gettime came in POSIX.1b (1993) +# CLOCK_MONOTONIC came in POSIX.1-2001 / SUSv3 as optional +# posix_memalign came in POSIX.1-2001 / SUSv3 +# M_PI is an XSI extension since POSIX.1-2001 / SUSv3, came in XPG1 (1985) +# ref: https://github.com/ggerganov/whisper.cpp/pull/1027 +CFLAGS += -D_XOPEN_SOURCE=600 +CXXFLAGS += -D_XOPEN_SOURCE=600 + ifdef LLAMA_DEBUG CFLAGS += -O0 -g CXXFLAGS += -O0 -g diff --git a/ggml.c b/ggml.c index e3f0c939c..1a441eb98 100644 --- a/ggml.c +++ b/ggml.c @@ -1,4 +1,3 @@ -#define _GNU_SOURCE // Defines CLOCK_MONOTONIC on Linux #define _CRT_SECURE_NO_DEPRECATE // Disables ridiculous "unsafe" warnigns on Windows #include "ggml.h" @@ -13387,8 +13386,7 @@ static void ggml_compute_forward_conv_2d_sk_p0_f16_f32( const int nk1 = ne01; // size of the convolution row - the kernel size unrolled across all channels - // round-up so it is more suitable for SIMD - const int ew0 = ggml_up32(nk0*nk1*ne02); + const int ew0 = nk0*nk1*ne02; GGML_ASSERT(nb00 == sizeof(ggml_fp16_t)); GGML_ASSERT(nb10 == sizeof(float)); diff --git a/llama-util.h b/llama-util.h index 4f8a4296a..0393fedec 100644 --- a/llama-util.h +++ b/llama-util.h @@ -53,6 +53,7 @@ __attribute__((format(gnu_printf, 1, 2))) __attribute__((format(printf, 1, 2))) #endif #endif + static std::string format(const char * fmt, ...) { va_list ap, ap2; va_start(ap, fmt); diff --git a/llama.cpp b/llama.cpp index ac22a48f8..995e7f048 100644 --- a/llama.cpp +++ b/llama.cpp @@ -1,11 +1,3 @@ -// Defines fileno on msys: -#ifndef _GNU_SOURCE -#define _GNU_SOURCE -#include -#include -#include -#endif - #include "llama-util.h" #include "llama.h"