mirror of
https://github.com/ggerganov/llama.cpp.git
synced 2024-12-26 14:20:31 +01:00
llama : std::move llm_bigram_bpe from work_queue (#9062)
* llama : std::move llm_bigram_bpe from work_queue This commit updates the retrieval of llm_bigram_bpe objects from work_queue.top() by using std::move. The motivation for this is to avoid the copying of the std::string `text` member of the llm_bigram_bpe struct. * squash! llama : std::move llm_bigram_bpe from work_queue Introduced a MovablePriorityQueue class to allow moving elements out of the priority queue for llm_bigram_bpe. * squash! llama : std::move llm_bigram_bpe from work_queue Rename MovablePriorityQueue to lama_priority_queue. * squash! llama : std::move llm_bigram_bpe from work_queue Rename lama_priority_queue -> llama_priority_queue.
This commit is contained in:
parent
2f3c1466ff
commit
8455340b87
@ -321,6 +321,21 @@ private:
|
|||||||
|
|
||||||
// TODO: there are a lot of common parts between spm and bpe tokenizers, should be refactored and reused
|
// TODO: there are a lot of common parts between spm and bpe tokenizers, should be refactored and reused
|
||||||
|
|
||||||
|
template<typename T, typename Container = std::vector<T>, typename Compare = std::less<typename Container::value_type>>
|
||||||
|
class llama_priority_queue : public std::priority_queue<T, Container, Compare> {
|
||||||
|
public:
|
||||||
|
using std::priority_queue<T, Container, Compare>::priority_queue;
|
||||||
|
|
||||||
|
T pop_move() {
|
||||||
|
T item = std::move(this->c.front());
|
||||||
|
std::pop_heap(this->c.begin(), this->c.end(), this->comp);
|
||||||
|
this->c.pop_back();
|
||||||
|
return item;
|
||||||
|
}
|
||||||
|
|
||||||
|
void pop() = delete;
|
||||||
|
};
|
||||||
|
|
||||||
struct llm_bigram_bpe {
|
struct llm_bigram_bpe {
|
||||||
struct comparator {
|
struct comparator {
|
||||||
bool operator()(const llm_bigram_bpe & l, const llm_bigram_bpe & r) const {
|
bool operator()(const llm_bigram_bpe & l, const llm_bigram_bpe & r) const {
|
||||||
@ -329,7 +344,7 @@ struct llm_bigram_bpe {
|
|||||||
};
|
};
|
||||||
|
|
||||||
using queue_storage = std::vector<llm_bigram_bpe>;
|
using queue_storage = std::vector<llm_bigram_bpe>;
|
||||||
using queue = std::priority_queue<llm_bigram_bpe, queue_storage, comparator>;
|
using queue = llama_priority_queue<llm_bigram_bpe, queue_storage, comparator>;
|
||||||
llm_symbol::index left;
|
llm_symbol::index left;
|
||||||
llm_symbol::index right;
|
llm_symbol::index right;
|
||||||
std::string text;
|
std::string text;
|
||||||
@ -520,8 +535,7 @@ struct llm_tokenizer_bpe {
|
|||||||
|
|
||||||
// build token(s)
|
// build token(s)
|
||||||
while (!work_queue.empty()) {
|
while (!work_queue.empty()) {
|
||||||
auto bigram = work_queue.top();
|
auto bigram = work_queue.pop_move();
|
||||||
work_queue.pop();
|
|
||||||
|
|
||||||
auto & left_symbol = symbols[bigram.left];
|
auto & left_symbol = symbols[bigram.left];
|
||||||
auto & right_symbol = symbols[bigram.right];
|
auto & right_symbol = symbols[bigram.right];
|
||||||
|
Loading…
Reference in New Issue
Block a user