mirror of
https://github.com/ggerganov/llama.cpp.git
synced 2025-01-15 14:50:51 +01:00
contrib : add naming guidelines (cont) (#11177)
This commit is contained in:
parent
437e05f714
commit
a29f0870d4
@ -34,9 +34,9 @@
|
|||||||
struct llama_context * ctx;
|
struct llama_context * ctx;
|
||||||
const enum llama_rope_type rope_type;
|
const enum llama_rope_type rope_type;
|
||||||
```
|
```
|
||||||
|
|
||||||
_(NOTE: this guideline is yet to be applied to the `llama.cpp` codebase. New code should follow this guideline.)_
|
_(NOTE: this guideline is yet to be applied to the `llama.cpp` codebase. New code should follow this guideline.)_
|
||||||
|
|
||||||
- Try to follow the existing patterns in the code (indentation, spaces, etc.). In case of doubt use `clang-format` to format the added code
|
- Try to follow the existing patterns in the code (indentation, spaces, etc.). In case of doubt use `clang-format` to format the added code
|
||||||
- For anything not covered in the current guidelines, refer to the [C++ Core Guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)
|
- For anything not covered in the current guidelines, refer to the [C++ Core Guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines)
|
||||||
- Tensors store data in row-major order. We refer to dimension 0 as columns, 1 as rows, 2 as matrices
|
- Tensors store data in row-major order. We refer to dimension 0 as columns, 1 as rows, 2 as matrices
|
||||||
@ -105,7 +105,7 @@
|
|||||||
|
|
||||||
# Preprocessor directives
|
# Preprocessor directives
|
||||||
|
|
||||||
- (TODO: add guidelines with examples and apply them to the codebase)
|
- _(TODO: add guidelines with examples and apply them to the codebase)_
|
||||||
|
|
||||||
```cpp
|
```cpp
|
||||||
#ifdef FOO
|
#ifdef FOO
|
||||||
|
Loading…
Reference in New Issue
Block a user