llama.cpp/.github/workflows
Gavin Zhao 82ca83db3c
ROCm: use native CMake HIP support (#5966)
Supercedes #4024 and #4813.

CMake's native HIP support has become the
recommended way to add HIP code into a project (see
[here](https://rocm.docs.amd.com/en/docs-6.0.0/conceptual/cmake-packages.html#using-hip-in-cmake)).
This PR makes the following changes:

1. The environment variable `HIPCXX` or CMake option
`CMAKE_HIP_COMPILER` should be used to specify the HIP
compiler. Notably this shouldn't be `hipcc`, but ROCm's clang,
which usually resides in `$ROCM_PATH/llvm/bin/clang`. Previously
this was control by `CMAKE_C_COMPILER` and `CMAKE_CXX_COMPILER`.
Note that since native CMake HIP support is not yet available on
Windows, on Windows we fall back to the old behavior.

2. CMake option `CMAKE_HIP_ARCHITECTURES` is used to control the
GPU architectures to build for. Previously this was controled by
`GPU_TARGETS`.

3. Updated the Nix recipe to account for these new changes.

4. The GPU targets to build against in the Nix recipe is now
consistent with the supported GPU targets in nixpkgs.

5. Added CI checks for HIP on both Linux and Windows. On Linux, we test
both the new and old behavior.

The most important part about this PR is the separation of the
HIP compiler and the C/C++ compiler. This allows users to choose
a different C/C++ compiler if desired, compared to the current
situation where when building for ROCm support, everything must be
compiled with ROCm's clang.

~~Makefile is unchanged. Please let me know if we want to be
consistent on variables' naming because Makefile still uses
`GPU_TARGETS` to control architectures to build for, but I feel
like setting `CMAKE_HIP_ARCHITECTURES` is a bit awkward when you're
calling `make`.~~ Makefile used `GPU_TARGETS` but the README says
to use `AMDGPU_TARGETS`. For consistency with CMake, all usage of
`GPU_TARGETS` in Makefile has been updated to `AMDGPU_TARGETS`.

Thanks to the suggestion of @jin-eld, to maintain backwards
compatibility (and not break too many downstream users' builds), if
`CMAKE_CXX_COMPILER` ends with `hipcc`, then we still compile using
the original behavior and emit a warning that recommends switching
to the new HIP support. Similarly, if `AMDGPU_TARGETS` is set but
`CMAKE_HIP_ARCHITECTURES` is not, then we forward `AMDGPU_TARGETS`
to `CMAKE_HIP_ARCHITECTURES` to ease the transition to the new
HIP support.

Signed-off-by: Gavin Zhao <git@gzgz.dev>
2024-05-17 17:03:03 +02:00
..
bench.yml Disable benchmark on forked repo (#7034) 2024-05-05 13:38:55 +02:00
build.yml ROCm: use native CMake HIP support (#5966) 2024-05-17 17:03:03 +02:00
close-issue.yml ci : exempt confirmed bugs from being tagged as stale (#7014) 2024-05-01 08:13:59 +03:00
code-coverage.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00
docker.yml [bug fix] convert github repository_owner to lowercase (#6673) 2024-04-14 13:12:36 +02:00
editorconfig.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00
gguf-publish.yml ci : update checkout, setup-python and upload-artifact to latest (#6456) 2024-04-03 21:01:13 +03:00
nix-ci-aarch64.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00
nix-ci.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00
nix-flake-update.yml ci: nix-flake-update: new token with pr permissions (#4879) 2024-01-11 17:22:34 +00:00
nix-publish-flake.yml workflows: nix-flakestry: drop tag filters 2023-12-31 13:14:58 -08:00
python-check-requirements.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00
python-lint.yml convert.py : add python logging instead of print() (#6511) 2024-05-03 22:36:41 +03:00
server.yml build(cmake): simplify instructions (cmake -B build && cmake --build build ...) (#6964) 2024-04-29 17:02:45 +01:00
zig-build.yml ci: exempt master branch workflows from getting cancelled (#6486) 2024-04-04 18:30:53 +02:00