From 7f9c1cbb30b13a313923d994b34ce175c522f9d8 Mon Sep 17 00:00:00 2001 From: oobabooga <112222186+oobabooga@users.noreply.github.com> Date: Fri, 3 Nov 2023 08:25:22 -0700 Subject: [PATCH] Change min_p default to 0.0 --- extensions/api/util.py | 2 +- modules/presets.py | 2 +- modules/sampler_hijack.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/api/util.py b/extensions/api/util.py index 74398147..4fb2720a 100644 --- a/extensions/api/util.py +++ b/extensions/api/util.py @@ -26,7 +26,7 @@ def build_parameters(body, chat=False): 'do_sample': bool(body.get('do_sample', True)), 'temperature': float(body.get('temperature', 0.5)), 'top_p': float(body.get('top_p', 1)), - 'min_p': float(body.get('min_p', 1)), + 'min_p': float(body.get('min_p', 0)), 'typical_p': float(body.get('typical_p', body.get('typical', 1))), 'epsilon_cutoff': float(body.get('epsilon_cutoff', 0)), 'eta_cutoff': float(body.get('eta_cutoff', 0)), diff --git a/modules/presets.py b/modules/presets.py index bebf9246..27bd2cba 100644 --- a/modules/presets.py +++ b/modules/presets.py @@ -9,7 +9,7 @@ def default_preset(): 'do_sample': True, 'temperature': 1, 'top_p': 1, - 'min_p': 1, + 'min_p': 0, 'top_k': 0, 'typical_p': 1, 'epsilon_cutoff': 0, diff --git a/modules/sampler_hijack.py b/modules/sampler_hijack.py index 2fda401c..a4fee744 100644 --- a/modules/sampler_hijack.py +++ b/modules/sampler_hijack.py @@ -252,7 +252,7 @@ def get_logits_processor_patch(self, **kwargs): def generation_config_init_patch(self, **kwargs): self.__init___old(**kwargs) - self.min_p = kwargs.pop("min_p", 1.0) + self.min_p = kwargs.pop("min_p", 0.0) self.tfs = kwargs.pop("tfs", 1.0) self.top_a = kwargs.pop("top_a", 0.0) self.mirostat_mode = kwargs.pop("mirostat_mode", 0)